Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing emitWarning import #24587

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix: missing emitWarning import #24587

merged 3 commits into from
Jul 19, 2024

Conversation

marvinhagemeister
Copy link
Contributor

We were missing an import of emitWarning in our streams implementation. The code prior to this PR assumed that process would be available as a global.

Fixes #23709

@bartlomieju bartlomieju enabled auto-merge (squash) July 19, 2024 22:59
@bartlomieju bartlomieju merged commit c77b8b9 into main Jul 19, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix-missing-process branch July 19, 2024 23:35
bartlomieju added a commit that referenced this pull request Jul 22, 2024
We were missing an import of `emitWarning` in our streams
implementation. The code prior to this PR assumed that `process` would
be available as a global.

Fixes #23709

---------

Co-authored-by: Bartek Iwańczuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std/node/_events.mjs assumes existence of process, crashes on calling process.emitWarning
3 participants