Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(init): use bare specifier for jsr:@std/assert #24581

Merged
merged 2 commits into from
Jul 14, 2024
Merged

fix(init): use bare specifier for jsr:@std/assert #24581

merged 2 commits into from
Jul 14, 2024

Conversation

dsherret
Copy link
Member

Closes #24580

dsherret
dsherret commented Jul 14, 2024
View reviewed changes
cli/tools/init/mod.rs
@@ -53,10 53,13 @@ Deno.test(function addTest() {
"deno.json",
&json!({
"name": project_name,
"version": "1.0.0",
"version": "0.1.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better starting version IMO because you rarely release a 1.0.0 version the first time.

@dsherret dsherret merged commit 8754a01 into denoland:main Jul 14, 2024
17 checks passed
@dsherret dsherret deleted the fix_bare_specifier_std_assert_init branch July 14, 2024 17:22
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
@dsherret @bartlomieju
fix(init): use bare specifier for jsr:@std/assert (#24581)
7caefa9 
Closes #24580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno init should have @std/assert as bare specifier
2 participants
@dsherret @ry