Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): unfurling should always be done with the package json #24435

Merged
merged 6 commits into from
Jul 5, 2024
Merged

fix(publish): unfurling should always be done with the package json #24435

merged 6 commits into from
Jul 5, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 4, 2024

Closes #24430

@dsherret dsherret marked this pull request as draft July 4, 2024 21:36
@dsherret dsherret changed the title fix(publish): always use pkg json dep resolution fix(publish): unfurling should always be done with the package json Jul 4, 2024
dsherret
dsherret commented Jul 4, 2024
View reviewed changes
cli/tools/registry/unfurl.rs
specifier,
referrer,
relative_resolved
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the example repo:

deno::tools::registry::unfurl:156 - Unfurled specifier: lodash from file:///.../jsr-publish-fails-repro/src/index.ts -> npm:lodash@^4.17.21

@dsherret dsherret requested a review from bartlomieju July 4, 2024 22:05
@dsherret dsherret marked this pull request as ready for review July 4, 2024 22:05
bartlomieju
bartlomieju approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this one took a while 😅

@dsherret dsherret enabled auto-merge (squash) July 5, 2024 00:32
@dsherret dsherret merged commit f396b3d into denoland:main Jul 5, 2024
17 checks passed
@dsherret dsherret deleted the fix_deno_publish_byonm branch July 5, 2024 01:18
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@dsherret @zebreus
fix(publish): unfurling should always be done with the package json (d…
5db81f6 
…enoland#24435)

Closes denoland#24430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx jsr publish fails due to graphError
2 participants
@dsherret @bartlomieju