Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): correct scope attribution for injected @types/node #24404

Merged
merged 3 commits into from
Jul 3, 2024
Merged

fix(lsp): correct scope attribution for injected @types/node #24404

merged 3 commits into from
Jul 3, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #24401.

nathanwhit
nathanwhit reviewed Jul 3, 2024
View reviewed changes
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
nathanwhit
nathanwhit approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit dd6d19e into denoland:main Jul 3, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-node-types branch July 3, 2024 19:54
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@nayeemrmn @zebreus
fix(lsp): correct scope attribution for injected @types/node (denolan…
36ec5f9 
…d#24404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No types for node builtin modules in LSP
2 participants
@nayeemrmn @nathanwhit