Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permissions): handle ipv6 addresses correctly #24397

Merged
merged 6 commits into from
Jul 5, 2024
Merged

fix(permissions): handle ipv6 addresses correctly #24397

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
ef760f5
fix(permissions): handle ipv6 addresses correctly
lucacasonato Jul 3, 2024
f7262b0
fix tests
lucacasonato Jul 3, 2024
d76c658
fix more
lucacasonato Jul 3, 2024
1619cc3
fix tests
lucacasonato Jul 4, 2024
a0ab36d
fix
lucacasonato Jul 5, 2024
9fc5139
fmt
lucacasonato Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@lucacasonato
lucacasonato committed Jul 5, 2024
commit a0ab36dae117bcbd15df47e3a60d1ecf88c92580
12 changes: 11 additions & 1 deletion runtime/permissions/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,8 717,13 @@ impl FromStr for Host {
}
Ok(Host::Ip(ip))
} else {
let lower = if s.chars().all(|c| c.is_ascii_lowercase()) {
Cow::Borrowed(s)
} else {
Cow::Owned(s.to_ascii_lowercase())
};
let fqdn =
FQDN::from_str(s).with_context(|| format!("invalid host: '{s}'"))?;
FQDN::from_str(&lower).with_context(|| format!("invalid host: '{s}'"))?;
if fqdn.is_root() {
return Err(uri_error(format!("invalid empty host: '{s}'")));
}
Expand Down Expand Up @@ -3496,6 3501,7 @@ mod tests {
fn test_host_parse() {
let hosts = &[
("deno.land", Some(Host::Fqdn(fqdn!("deno.land")))),
("DENO.land", Some(Host::Fqdn(fqdn!("deno.land")))),
("deno.land.", Some(Host::Fqdn(fqdn!("deno.land")))),
(
"1.1.1.1",
Expand Down Expand Up @@ -3537,6 3543,10 @@ mod tests {
"deno.land",
Some(NetDescriptor(Host::Fqdn(fqdn!("deno.land")), None)),
),
(
"DENO.land",
Some(NetDescriptor(Host::Fqdn(fqdn!("deno.land")), None)),
),
(
"deno.land:8000",
Some(NetDescriptor(Host::Fqdn(fqdn!("deno.land")), Some(8000))),
Expand Down
Loading