fix(permissions): handle ipv6 addresses correctly #24397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
fix_permission_issue
branch
from
7991fe7
to
0f340b9
Compare
|
This does now disallow this, which was previously allowed: The reason for this, is is that this is ambiguous - it's either |
Also don't panic on invalid domain names and addresses. Co-authored-by: Yazan AbdAl-Rahman <[email protected]>
lucacasonato
force-pushed
the
fix_permission_issue
branch
from
0f340b9
to
ef760f5
Compare
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Also don't panic on invalid domain names and addresses. Extracted with cleanups up from denoland#24080 Co-authored-by: Yazan AbdAl-Rahman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't panic on invalid domain names and addresses.
Extracted with cleanups up from #24080
Fixes #23294
Co-authored-by: Yazan AbdAl-Rahman [email protected]