fix(ext/web): use primordials of ES2024 ArrayBuffer transfer #24396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petamoriken
commented
Jul 2, 2024
ext/web/06_streams.js
Outdated
| @@ -1359,7 1350,7 @@ function readableByteStreamControllerEnqueue(controller, chunk) { | |||
| "chunk's buffer is detached and so cannot be enqueued", | |||
| ); | |||
| } | |||
| const transferredBuffer = transferArrayBuffer(buffer); | |||
| const transferredBuffer = ArrayBufferPrototypeTransfer(buffer); | |||
There was a problem hiding this comment.
Oh, [[ArrayBufferMaxByteLength]] internal slot is not carried over, so ArrayBufferPrototypeTransferToFixedLength should be used.
https://streams.spec.whatwg.org/#transfer-array-buffer
bartlomieju
pushed a commit
to denoland/deno_core
that referenced
this pull request
Jul 2, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: denoland/deno_core#135