Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): don't wait for end() call to send http client request #24390

Merged
merged 7 commits into from
Jul 3, 2024
Merged

fix(ext/node): don't wait for end() call to send http client request #24390

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift click to select a range
bdd6bd1
fix(ext/node): don't wait for end() call to send http client request
satyarohith Jul 2, 2024
df67075
lint
satyarohith Jul 2, 2024
8f602eb
ignore the writer close error
satyarohith Jul 3, 2024
e513469
add test
satyarohith Jul 3, 2024
b4d0411
Merge remote-tracking branch 'upstream/main' into fix_http_client_req…
satyarohith Jul 3, 2024
fb6170d
fix fmt
satyarohith Jul 3, 2024
6f97a22
fix file path
satyarohith Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@satyarohith
satyarohith committed Jul 2, 2024
commit df67075cf75215ebddb36dd4916f68ffa18564c3
10 changes: 5 additions & 5 deletions ext/node/polyfills/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,11 630,6 @@ class ClientRequest extends OutgoingMessage {
if (this._req.cancelHandleRid !== null) {
core.tryClose(this._req.cancelHandleRid);
}
try {
cb?.();
} catch (_) {
//
}
if (this._timeout) {
this._timeout.removeEventListener("abort", this._timeoutCb);
webClearTimeout(this._timeout[timerId]);
Expand Down Expand Up @@ -786,6 781,11 @@ class ClientRequest extends OutgoingMessage {
this._send("", "latin1");
}
this._bodyWriter?.close();
try {
cb?.();
} catch (_) {
//
}
}

abort() {
Expand Down