Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent setting unstable feature twice #24381

Merged
merged 6 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add-test: Added test to show the case of duplicate unstable feature flag
  • Loading branch information
HasanAlrimawi committed Jul 2, 2024
commit b3d5cd57db8cfa69925fc388b12b36b1d0d9ac6e
1 change: 1 addition & 0 deletions tests/specs/compile/repetitive_unstable_flag/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 1 @@
out.exe
13 changes: 13 additions & 0 deletions tests/specs/compile/repetitive_unstable_flag/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 1,13 @@
{
"steps": [
{
"args": "compile --unstable-kv -A --output out main.ts",
"output": "compile.out"
},
{
"commandName": "./out",
"args": [],
"output": "main.out"
}
]
}
2 changes: 2 additions & 0 deletions tests/specs/compile/repetitive_unstable_flag/compile.out
Original file line number Diff line number Diff line change
@@ -0,0 1,2 @@
Check [WILDCARD]main.ts
Compile [WILDCARD]main.ts to out.exe
3 changes: 3 additions & 0 deletions tests/specs/compile/repetitive_unstable_flag/deno.json
Original file line number Diff line number Diff line change
@@ -0,0 1,3 @@
{
"unstable": ["kv"]
}
1 change: 1 addition & 0 deletions tests/specs/compile/repetitive_unstable_flag/main.out
Original file line number Diff line number Diff line change
@@ -0,0 1 @@
Duplicate unstable feature issue is resolved as you can see
1 change: 1 addition & 0 deletions tests/specs/compile/repetitive_unstable_flag/main.ts
Original file line number Diff line number Diff line change
@@ -0,0 1 @@
console.log("Duplicate unstable feature issue is resolved as you can see");
Loading