Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jupyter): move ZeroMQ server to a separate thread #24373

Merged
merged 6 commits into from
Jul 2, 2024
Merged

refactor(jupyter): move ZeroMQ server to a separate thread #24373

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
6600ddd
factor out ReplSessionProxy
bartlomieju Jun 28, 2024
310a793
hoist out replsessionproxy
bartlomieju Jun 28, 2024
dba8b73
oooh, it's compiling :>
bartlomieju Jun 29, 2024
ac4c0c0
fix an op
bartlomieju Jun 30, 2024
6f08015
Merge branch 'main' into jupyter_zeromq_thread
bartlomieju Jul 1, 2024
40973a3
renames
bartlomieju Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix an op
  • Loading branch information
@bartlomieju
bartlomieju committed Jun 30, 2024
commit ac4c0c009ab9f1ad0eef99b291dad844a55f175a
4 changes: 2 additions & 2 deletions cli/ops/jupyter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 45,11 @@ pub async fn op_jupyter_broadcast(

(
s.borrow::<Arc<Mutex<KernelIoPubConnection>>>().clone(),
s.borrow::<Rc<RefCell<Option<JupyterMessage>>>>().clone(),
s.borrow::<Arc<Mutex<Option<JupyterMessage>>>>().clone(),
)
};

let maybe_last_request = last_execution_request.borrow().clone();
let maybe_last_request = last_execution_request.lock().await.clone();
if let Some(last_request) = maybe_last_request {
let content = JupyterMessageContent::from_type_and_content(
&message_type,
Expand Down