Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(unstable/ffi): remove callback reentrant flag #24367

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

littledivy
Copy link
Member

Closes #22947

This option is no longer needed as fast calls are now allowed to re-enter the isolate

Fast calls can re-enter the isolate
@littledivy littledivy requested a review from aapoalas June 29, 2024 03:17
@littledivy littledivy merged commit cd4a007 into denoland:main Jul 1, 2024
17 checks passed
@littledivy littledivy deleted the rm_ffi_reentrant branch July 1, 2024 04:08
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
Closes denoland#22947

This option is no longer needed as fast calls are now allowed to
re-enter the isolate
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Closes denoland#22947

This option is no longer needed as fast calls are now allowed to
re-enter the isolate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FFI Crash with "DisallowJavascriptExecutionScope" when callback is called many times
2 participants