Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): respect lockfile redirects entries for resolution #24365

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(lsp): respect lockfile redirects entries for resolution #24365

merged 1 commit into from
Jul 1, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jun 28, 2024 •
edited
Loading

No description provided.

@nayeemrmn nayeemrmn requested a review from dsherret June 28, 2024 21:44
dsherret
dsherret approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 38a6be2 into denoland:main Jul 1, 2024
17 checks passed
@bartlomieju bartlomieju mentioned this pull request Jul 1, 2024
Merged
bartlomieju added a commit that referenced this pull request Jul 1, 2024
@bartlomieju
fix(lsp): use CliLockfile (#24387)
b0cd43b 
The build broke in #24365.
@nayeemrmn nayeemrmn deleted the lsp-lockfile-redirect-resolution branch July 2, 2024 01:15
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
@nayeemrmn @sbmsr
fix(lsp): respect lockfile redirects entries for resolution (denoland…
bc8bb12 
…#24365)
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
@bartlomieju @sbmsr
fix(lsp): use CliLockfile (denoland#24387)
d40af5c 
The build broke in denoland#24365.
@sbmsr sbmsr mentioned this pull request Jul 2, 2024
Closed
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@nayeemrmn @zebreus
fix(lsp): respect lockfile redirects entries for resolution (denoland…
095580f 
…#24365)
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@bartlomieju @zebreus
fix(lsp): use CliLockfile (denoland#24387)
d790792 
The build broke in denoland#24365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @dsherret