feat: upgrade deno_core #24364
Merged
feat: upgrade deno_core #24364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devsnek
commented
Jun 28, 2024
devsnek
commented
- Symbol.asyncDispose no longer needs to be polyfilled
- assorted updates for cppgc api changes
littledivy
reviewed
Jun 28, 2024
Comment on lines
66
to
70
| impl deno_core::GarbageCollected for ContextifyContext { | ||
| fn trace(&self, visitor: &v8::cppgc::Visitor) { | ||
| visitor.trace(&self.context); | ||
| visitor.trace(&self.sandbox); | ||
| } |
devsnek
force-pushed
the
deno-core-upgrade
branch
from
30d04c6
to
6db1f3a
Compare
devsnek
force-pushed
the
deno-core-upgrade
branch
from
6db1f3a
to
06d17b6
Compare
devsnek
force-pushed
the
deno-core-upgrade
branch
from
06d17b6
to
159ccff
Compare
bartlomieju
approved these changes
Jul 1, 2024
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
- Symbol.asyncDispose no longer needs to be polyfilled - assorted updates for cppgc api changes
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
- Symbol.asyncDispose no longer needs to be polyfilled - assorted updates for cppgc api changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.