Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Add --frozen flag to error out if lockfile is out of date #24355

Merged
merged 16 commits into from
Jul 2, 2024
Merged

feat(cli): Add --frozen flag to error out if lockfile is out of date #24355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift click to select a range
c067bb2
Add frozen flag
nathanwhit Jun 25, 2024
2985931
Make sure we error before modifying node_modules
nathanwhit Jun 27, 2024
78ace03
Add spec tests
nathanwhit Jun 27, 2024
39abb22
Add diff to message
nathanwhit Jun 27, 2024
eaa47f4
Appease clippy
nathanwhit Jun 27, 2024
28b98e0
Rename some fields
nathanwhit Jun 27, 2024
e7c2462
Tweak error msg
nathanwhit Jun 27, 2024
2cca787
Update output
nathanwhit Jun 27, 2024
8b450a3
Rework with new changes
nathanwhit Jun 29, 2024
3975427
Whitespace change
nathanwhit Jun 29, 2024
11ea98a
Add additional tests
nathanwhit Jul 2, 2024
19fec7e
Fix test
nathanwhit Jul 2, 2024
4563f51
allow --frozen=false
nathanwhit Jul 2, 2024
67d1612
Update dynamic import tests
nathanwhit Jul 2, 2024
2b79475
Use `--frozen=false` in error msg
nathanwhit Jul 2, 2024
4fa5f24
Skip lock if not frozen
nathanwhit Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update output
  • Loading branch information
@nathanwhit
nathanwhit committed Jun 29, 2024
commit 2cca787ddedd94eea7eef499bb22e0c1f2b019d2
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_cache.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 6,6 @@ changes:
11 | - }
12 | },
13 | "@denotest/[email protected]": {
14 | "integrity": "sha512-dxGTiMVdqnsZgewLxLifDdUskXs5pznErABlPE8kDHaHR2MS9coLuwpqOrkb0jxx4xTKnFrdR/ r4rudmvo5zA==",
14 | "integrity": "[WILDCARD]",
15 | "dependencies": {}
16 | }
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_jsr_cache.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 8,5 @@ changes:
7 | },
8 | "jsr": {
9 | "@denotest/[email protected]": {
10 | "integrity": "a9076d30ecb42b2fc6dd95e7055fbf4e6358b53f550741bd7f60089d19f68848"
10 | "integrity": "[WILDCARD]"
11 | },
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_jsr_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 10,5 @@ changes:
7 | },
8 | "jsr": {
9 | "@denotest/[email protected]": {
10 | "integrity": "a9076d30ecb42b2fc6dd95e7055fbf4e6358b53f550741bd7f60089d19f68848"
10 | "integrity": "[WILDCARD]"
11 | },
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_new_dep_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 7,6 @@ changes:
11 | - }
12 | },
13 | "@denotest/[email protected]": {
14 | "integrity": "sha512-dxGTiMVdqnsZgewLxLifDdUskXs5pznErABlPE8kDHaHR2MS9coLuwpqOrkb0jxx4xTKnFrdR/ r4rudmvo5zA==",
14 | "integrity": "[WILDCARD]",
15 | "dependencies": {}
16 | }
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_package_json_changed.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 10,7 @@ changes:
14 | - "remote": {}
12 | },
13 | "@denotest/[email protected]": {
14 | "integrity": "sha512-IKNzP1q9lJzTNyePIvLWffODL5v73KPLa IKhKVw1iV9cqmAxrHLM7wX3lizWSOj 1lY30QU/say0T6os J6cQ==",
14 | "integrity": "[WILDCARD]",
15 | "dependencies": {}
16 | }
17 | }
Expand Down
2 changes: 1 addition & 1 deletion tests/specs/lockfile/frozen_lockfile/frozen_package_json_changed_install.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 10,7 @@ changes:
14 | - "remote": {}
12 | },
13 | "@denotest/[email protected]": {
14 | "integrity": "sha512-IKNzP1q9lJzTNyePIvLWffODL5v73KPLa IKhKVw1iV9cqmAxrHLM7wX3lizWSOj 1lY30QU/say0T6os J6cQ==",
14 | "integrity": "[WILDCARD]",
15 | "dependencies": {}
16 | }
17 | }
Expand Down
Empty file added tests/specs/lockfile/frozen_lockfile/update_lockfile_jsr.out
View file
Open in desktop
nathanwhit marked this conversation as resolved.
Show resolved Hide resolved
Empty file.
1 change: 0 additions & 1 deletion tests/specs/npm/npmrc_not_next_to_package_json/main.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 4,3 @@
[WILDCARD]
Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz
Initialize @denotest/[email protected]
[WILDCARD]