feat(cli): Add --frozen flag to error out if lockfile is out of date
#24355
477
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
frozen-lockfile
branch
from
6de7f8a
to
8908220
Compare
dsherret
reviewed
Jun 27, 2024
nathanwhit
added a commit
that referenced
this pull request
Jun 29, 2024
As suggested in #24355 (comment). I wasn't able to hide the mutex stuff as much as I'd like (ended up just adding an escape hatch `inner()` method that locks the inner mutex), because you can't return references to the inner fields through a mutex. This is mostly motivated by the frozen lockfile changes
nathanwhit
force-pushed
the
frozen-lockfile
branch
3 times, most recently
from
66d248a
to
87d8ecc
Compare
nathanwhit
force-pushed
the
frozen-lockfile
branch
from
87d8ecc
to
8b450a3
Compare
dsherret
reviewed
Jul 1, 2024
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
…and#24366) As suggested in denoland#24355 (comment). I wasn't able to hide the mutex stuff as much as I'd like (ended up just adding an escape hatch `inner()` method that locks the inner mutex), because you can't return references to the inner fields through a mutex. This is mostly motivated by the frozen lockfile changes
dsherret
reviewed
Jul 2, 2024
dsherret
approved these changes
Jul 2, 2024
cli/args/lockfile.rs
Outdated
| Err(err) => Err(err).with_context(|| { | ||
| format!("Failed reading lockfile '{}'", filename.display()) | ||
| }), | ||
| } | ||
| } | ||
| pub fn error_if_changed(&self) -> Result<(), AnyError> { | ||
| let lockfile = self.lockfile.lock(); | ||
| if self.frozen && lockfile.has_content_changed { |
There was a problem hiding this comment.
In the future, we should probably error on insert into the lockfile.
An issue at the moment, is if a dynamic import inserts into the lockfile then all future dynamic imports will fail.
bartlomieju
reviewed
Jul 2, 2024
bartlomieju
reviewed
Jul 2, 2024
dsherret
reviewed
Jul 2, 2024
bartlomieju
approved these changes
Jul 2, 2024
bartlomieju
added a commit
that referenced
this pull request
Jul 5, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
…and#24366) As suggested in denoland#24355 (comment). I wasn't able to hide the mutex stuff as much as I'd like (ended up just adding an escape hatch `inner()` method that locks the inner mutex), because you can't return references to the inner fields through a mutex. This is mostly motivated by the frozen lockfile changes
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
denoland#24355) Closes denoland#18296. Adds a `--frozen` (alias `--frozen-lockfile`) flag that errors out if the lockfile is out of date. This is useful for running in CI (where an out of date lockfile is usually a mistake) or to prevent accidental changes in dependencies. 
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
This commit deprecates `--lock-write` flag by removing it from the help output and printing a warning message when it's used. Users should use `--frozen=false` instead which was added in denoland#24355. Towards denoland#24167.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18296.
Adds a
--frozen(alias--frozen-lockfile) flag that errors out if the lockfile is out of date. This is useful for running in CI (where an out of date lockfile is usually a mistake) or to prevent accidental changes in dependencies.