fix(npm): resolve dynamic npm imports individually #24170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jun 10, 2024
There was a problem hiding this comment.
Main:
---- specs::npm::dynamic_npm_resolution_failure ----
command V:\deno\target\debug\deno.exe run -A main.ts
command cwd V:\deno\tests\specs\npm\dynamic_npm_resolution_failure
output path V:\deno\tests\specs\npm\dynamic_npm_resolution_failure\main.out
-- OUTPUT START --
Download http://localhost:4260/chalk
Download http://localhost:4260/@denotest/dep-cannot-parse
error: Error in @denotest/[email protected] parsing version requirement for dependency: @denotest/esm-basic@unknown-scheme:unknown
Invalid npm version requirement. Unexpected character.
unknown-scheme:unknown
~
Caused by:
0: Invalid npm version requirement. Unexpected character.
unknown-scheme:unknown
~
1: Unexpected character.
unknown-scheme:unknown
~
dsherret
commented
Jun 10, 2024
| @@ -771,9 763,7 @@ fn resolve_package_json_dep( | |||
| #[derive(Debug)] | |||
| pub struct WorkerCliNpmGraphResolver<'a> { | |||
| npm_resolver: Option<&'a Arc<dyn CliNpmResolver>>, | |||
| // use a cache per worker so that another worker doesn't clear the | |||
| // cache of another worker | |||
| memory_cache: Rc<RefCell<HashMap<String, Arc<NpmPackageInfo>>>>, | |||
There was a problem hiding this comment.
After some other refactors, this cache is only a bit of an optimization when many workers are doing npm resolution and the complexity is not worth keeping around for that edge case (it will still use a cache, but it will be a file system one).
bartlomieju
approved these changes
Jun 11, 2024
nathanwhit
added a commit
that referenced
this pull request
Jun 12, 2024
Fixes a regression introduced in #24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules.
nathanwhit
pushed a commit
that referenced
this pull request
Jun 13, 2024
nathanwhit
added a commit
that referenced
this pull request
Jun 13, 2024
Fixes a regression introduced in #24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules.
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
…nd#24190) Fixes a regression introduced in denoland#24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17802