-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle InvalidLabelChar in URL validation to prevent panic #24080
fix: handle InvalidLabelChar in URL validation to prevent panic #24080
Conversation
…ix-url-validation-panic
… fix-url-validation-panic # Conflicts: # runtime/permissions.rs
After updating the branch and resolving the merge conflict issue, I encountered a cyclic dependence issue; how can we resolve it? I need to change NetPermissions place to avoid cycle dependence issue? error: cyclic package dependency: package |
Hello @dsherret |
… fix-url-validation-panic
… fix-url-validation-panic
… fix-url-validation-panic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about removing new functionality.
mapping errors to URIErrors 'like the original behavior'.
…ix-url-validation-panic
@dsherret |
@dsherret I saw that via this reference: If you need to remove any functions, it will defect the permission system. |
…validation-panic # Conflicts: # ext/net/ops_tls.rs
@dsherret |
Also don't panic on invalid domain names and addresses. Extracted with cleanups up from #24080 Co-authored-by: Yazan AbdAl-Rahman <[email protected]>
Closing in favor of #24397 which landed parts of this PR. |
Also don't panic on invalid domain names and addresses. Extracted with cleanups up from denoland#24080 Co-authored-by: Yazan AbdAl-Rahman <[email protected]>
Fixes #23294
Fixes #23552