fix(node): instantiating process class without new #23865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
force-pushed
the
process-es5
branch
from
75454dc
to
09ae00d
Compare
bartlomieju
approved these changes
May 17, 2024
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
Popular test runners like Jest instantiate a new `Process` object themselves and expect the class constructor to be callable without the `new` keyword. This PR refactors our `Process` class implementation from a proper ES2015 class to an ES5-style class which can be invoked both with and without the `new` keyword like in Node. Fixes #23863
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
Popular test runners like Jest instantiate a new `Process` object themselves and expect the class constructor to be callable without the `new` keyword. This PR refactors our `Process` class implementation from a proper ES2015 class to an ES5-style class which can be invoked both with and without the `new` keyword like in Node. Fixes #23863
|
Sorry if this is an improper place to report this, but I believe something to do with this commit has broken an npm import for me. Now fails on launch due to process.versions being undefined. The code in the module: |
|
@reeceorbuck can you open an issue for that? Otherwise I'll forget about it on Monday, because it's difficult to keep track of comments on merged PRs here on GitHub. I just saw this comment by accident as I usually tend to clear anything that's marked as done or closed in my notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popular test runners like Jest instantiate a new
Processobject themselves and expect the class constructor to be callable without thenewkeyword. This PR refactors ourProcessclass implementation from a proper ES2015 class to an ES5-style class which can be invoked both with and without thenewkeyword like in Node.Fixes #23863