fix(ext/web): fix AbortSignal.timeout() leak
#23842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
#20663 is saying that a test like this should pass. Deno.test({
name: "regression for #20663",
fn: () => {
AbortSignal.timeout(2000);
},
}); |
mmastrac
reviewed
May 16, 2024
ext/web/03_abort_signal.js
Outdated
| @@ -120,6 120,7 @@ class AbortSignal extends EventTarget { | |||
| const signal = new AbortSignal(illegalConstructorKey); | |||
| signal[timerId] = setTimeout( | |||
There was a problem hiding this comment.
Note that Deno.core offers a queueSystemTimer to work around this sort of issue. Even with the changes made here, we will still be leaking a timer, as the timer is only ever cleared when the timer has fired (which should have already cleared the timer).
mmastrac
reviewed
May 16, 2024
tests/unit/timers_test.ts
Outdated
| name: "regression for #20663", | ||
| fn: async () => { | ||
| const signal = AbortSignal.timeout(2000); | ||
| const t = setTimeout(() => { |
There was a problem hiding this comment.
To properly test this fix, I believe you should create an AbortSignal.timeout and let it just leak out of the test.
littledivy
added a commit
to denoland/deno_core
that referenced
this pull request
Jun 18, 2024
iuioiua
changed the title
AbortSignal.timeout() leak
|
Thanks for the |
iuioiua
approved these changes
Jun 18, 2024
iuioiua
reviewed
Jun 18, 2024
Comment on lines
372
to
373
| [patch.crates-io] | ||
| deno_core = { git = "https://github.com/denoland/deno_core" } |
There was a problem hiding this comment.
I missed this before merging. My mistake.
bartlomieju
added a commit
that referenced
this pull request
Jun 18, 2024
A PR was landed by mistake that used `[patch.crates-io]` instead of released `deno_core` version: #23842 (comment)
bartlomieju
pushed a commit
that referenced
this pull request
Jun 18, 2024
<!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> Fixes #20663. --------- Co-authored-by: Asher Gomez <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
bartlomieju
added a commit
that referenced
this pull request
Jun 18, 2024
A PR was landed by mistake that used `[patch.crates-io]` instead of released `deno_core` version: #23842 (comment)
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
<!-- Before submitting a PR, please read https://docs.deno.com/runtime/manual/references/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix denoland#7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> Fixes denoland#20663. --------- Co-authored-by: Asher Gomez <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
A PR was landed by mistake that used `[patch.crates-io]` instead of released `deno_core` version: denoland#23842 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20663.