fix(node): resolve types via package.json for directory import #22878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 12, 2024
dsherret
commented
Mar 13, 2024
| if let Some(resolution) = maybe_resolution { | ||
| return Ok(Some(resolution)); | ||
| } | ||
| } |
There was a problem hiding this comment.
I looked into it and this seems to be done first before the index.d.ts probing.
dsherret
changed the title
bartlomieju
reviewed
Mar 14, 2024
Comment on lines
-514
to
-518
| throw new ERR_MODULE_NOT_FOUND( | ||
| filename, | ||
| path.resolve(pkgPath, "package.json"), | ||
| ); | ||
| } |
There was a problem hiding this comment.
IIRC this was quite an important bit and some packages were checking for this ERR_MODULE_NOT_FOUND code property. Does this value still match after this change?
There was a problem hiding this comment.
This code was not used so I removed it.
There was a problem hiding this comment.
Fair enough, let's land as is, but just a warning for the future. I'm not 100% sure this was the exact code path that was checking for this code.
bartlomieju
approved these changes
Mar 14, 2024
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Does a package resolve when resolving types for a directory (copying the behaviour that typescript does).
dsherret
added a commit
to dsherret/deno
that referenced
this pull request
Mar 15, 2024
…and#22878) Does a package resolve when resolving types for a directory (copying the behaviour that typescript does).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a package resolve when resolving types for a directory (copying the behaviour that typescript does).
Please merge on approval