Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(publish): support sloppy imports and bare node built-ins #22588

Merged
merged 7 commits into from
Feb 27, 2024
Merged

feat(publish): support sloppy imports and bare node built-ins #22588

merged 7 commits into from
Feb 27, 2024

Conversation

lucacasonato
Copy link
Member

No description provided.

@lucacasonato lucacasonato marked this pull request as ready for review February 26, 2024 18:50
@kwhinnery
Copy link
Contributor

Thanks for this! Will help with publishing existing codebases to JSR.

ry
ry reviewed Feb 27, 2024
View reviewed changes
test_util/std Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucacasonato lucacasonato enabled auto-merge (squash) February 27, 2024 15:09
@lucacasonato lucacasonato merged commit 8d5c231 into denoland:main Feb 27, 2024
17 checks passed
@lucacasonato lucacasonato deleted the feat_bare_node_builtins_and_sloppy_imports_publish branch February 27, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacasonato @kwhinnery @ry @dsherret