Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move test_ffi and test_nap to tests/ [WIP] #22394

Merged
merged 7 commits into from
Feb 12, 2024

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Feb 12, 2024

Moving some additional NAPI and. FFI tests out of the tree root.

@mmastrac mmastrac added the ci-bench put this on a PR to run the benchmarks label Feb 12, 2024
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wondered why test_ffi was in the root.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmastrac mmastrac merged commit f607200 into denoland:main Feb 12, 2024
17 checks passed
littledivy pushed a commit that referenced this pull request Feb 15, 2024
Moving some additional NAPI and. FFI tests out of the tree root.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-bench put this on a PR to run the benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants