Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): add node specifiers #22213

Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix(publish): add node specifiers #22213

merged 4 commits into from
Feb 1, 2024

Conversation

crowlKats
Copy link
Member

No description provided.

dsherret
dsherret approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bartlomieju
bartlomieju reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please test is somehow?

lucacasonato
lucacasonato reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@dsherret
Copy link
Member

dsherret commented Feb 1, 2024

Hey Leo, can you test this please?

@crowlKats
Copy link
Member Author

hey, should I add a test?

@crowlKats crowlKats merged commit e58b190 into denoland:main Feb 1, 2024
15 checks passed
@crowlKats crowlKats deleted the add-node-specifiers branch February 1, 2024 04:18
littledivy pushed a commit that referenced this pull request Feb 1, 2024
@crowlKats @littledivy
fix(publish): add node specifiers (#22213)
d9f3608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crowlKats @dsherret @lucacasonato @bartlomieju