fix(ext/node): add fs.cp, fs.cpSync, promises.cp #21745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Dec 31, 2023
| @@ -25,6 25,7 @@ fs3.workspace = true | |||
| libc.workspace = true | |||
| log.workspace = true | |||
| rand.workspace = true | |||
| rayon = "1.8.0" | |||
There was a problem hiding this comment.
Can't we use spawn_blocking instead. Bringing rayon for these APIs seems like a lot
There was a problem hiding this comment.
spawn_blocking cannot be used in non-async context.
Looking at Cargo.lock, rayon only adds crossbeam dependency. rayon is a little more suitable here because we want to parallelize large amounts of small file copies.
bartlomieju
approved these changes
Jan 5, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Jan 12, 2024
Fixes #20803 Fixes #21723 Performance: copying a 48GiB rust `target` folder (recursive) | Platform | `deno` | `node v21.5` | Improvement | | -------- | ------- | ------- | ------- | | macOS (APFS) | 3.1secs | 127.99 secs | **42x** | | Windows | 18.3secs | 67.2secs | **3.8x** | Copying files with varying sizes: 
|
I think you forgot to add it to https://github.com/littledivy/deno/blob/20bb2c8daaba6b78710a24014828f3db90e4e807/ext/node/polyfills/fs/promises.ts lol This fails in 1.40.3 import { cp } from "node:fs/promises"$ deno run -A z.js
error: Uncaught SyntaxError: The requested module 'node:fs/promises' does not provide an export named 'cp'
import { cp } from "node:fs/promises";
^
at <anonymous> (file:///workspaces/myworkspace/z.js:1:10) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20803
Fixes #21723
Performance: copying a 48GiB rust
targetfolder (recursive)denonode v21.5Copying files with varying sizes: