Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow npm: specifiers in import.meta.resolve #21716

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

bartlomieju
Copy link
Member

Closes #21298.

"npm:" specifiers are matched against import map entries
and if no match is found they are passed through.

@bartlomieju bartlomieju changed the title Fix import meta resolve fix: allow npm: specifiers in import.meta.resolve Dec 27, 2023
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 576b20a into denoland:main Dec 28, 2023
14 checks passed
@bartlomieju bartlomieju deleted the fix_import_meta_resolve branch December 28, 2023 19:37
bartlomieju added a commit that referenced this pull request Jan 4, 2024
Closes #21298.

"npm:" specifiers are matched against import map entries
and if no match is found they are passed through.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta.resolve with npm packages
2 participants