Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devcontainer): moved settings to customizations/vscode #21512

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix(devcontainer): moved settings to customizations/vscode #21512

merged 3 commits into from
Dec 19, 2023

Conversation

jcayzac
Copy link
Contributor

@jcayzac jcayzac commented Dec 8, 2023

The current configuration use the deprecated top-level settings and extensions keys. Those are now under customizations/vscode.

@jcayzac jcayzac marked this pull request as ready for review December 8, 2023 23:57
bartlomieju
bartlomieju approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartlomieju bartlomieju merged commit aefa205 into denoland:main Dec 19, 2023
14 checks passed
@jcayzac jcayzac deleted the fix/devcontainer branch January 12, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcayzac @bartlomieju