feat(compile): support discovering modules for more dynamic arguments #21381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 29, 2023
bartlomieju
approved these changes
Dec 1, 2023
Comment on lines
96
to
106
| if !success { | ||
| log::warn!( | ||
| "{} Dynamic import was not analyzable and won't use the import map once published.\n at {}", | ||
| crate::colors::yellow("Warning"), | ||
| format_range_with_colors(&deno_graph::Range { | ||
| specifier: url.clone(), | ||
| start: dep.range.start.clone(), | ||
| end: dep.range.end.clone(), | ||
| }) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could you add a test that exercised this warning?
There was a problem hiding this comment.
I wanted to, but we don't have any integration tests for publishing at the moment and refactoring this out to a returned diagnostic didn't seem worth it since there are some test cases for this scenario where it doesn't replace it.
|
Awesome. The |
|
@iuioiua and thank you for trying out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes Deno to include more files in the graph based on how a template literal looks that's provided to a dynamic import:
In this case, it will search the
dirdirectory and descendant directories for any .js/jsx/etc modules and include them in the graph.To opt out of this behaviour, move the template literal to a separate line:
Also, closes (due to deno_doc upgrade):
Closes #21405
Closes #21403
Closes #21390