Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ext/node): use libz-sys w/zlib-ng feature in node #21158

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Nov 10, 2023

We only want one zlib dependency.

Zlib dependencies are reorganized so they use a hidden __vendored_zlib_ng flag in cli that enables zlib-ng for both libz-sys (used by ext/node) and flate2 (used by deno_web).

@mmastrac mmastrac changed the title chore(ext/node): use lib-ng-sys in node chore(ext/node): use libz-sys w/zlib-ng feature in node Nov 10, 2023
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmastrac mmastrac merged commit 56e7624 into denoland:main Nov 11, 2023
13 checks passed
kt3k pushed a commit that referenced this pull request Nov 17, 2023
We only want one zlib dependency.

Zlib dependencies are reorganized so they use a hidden
`__vendored_zlib_ng` flag in cli that enables zlib-ng for both libz-sys
(used by ext/node) and flate2 (used by deno_web).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants