Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use pure rust secp256k1 crate #21154

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: use pure rust secp256k1 crate #21154

merged 1 commit into from
Nov 10, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Nov 10, 2023 •
edited
Loading

Saves ~40s in fresh debug build:

Before:

image

After:

image

mmastrac
mmastrac approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy
Copy link
Member Author

Blog post with benchmarks: https://iqlusion.blog/k256-crate-pure-rust-projective-secp256k1-library

(future reference for runtime performance)

@littledivy littledivy merged commit 05704fb into denoland:main Nov 10, 2023
13 checks passed
@littledivy littledivy deleted the secp256k1_change_crate branch November 10, 2023 17:29
kt3k pushed a commit that referenced this pull request Nov 17, 2023
@littledivy @kt3k
chore: use pure rust secp256k1 crate (#21154)
59b1e7d 
Saves ~40s in fresh debug build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @mmastrac