Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext): use String#toWellFormed in ext/webidl and ext/node #21054

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix(ext): use String#toWellFormed in ext/webidl and ext/node #21054

merged 3 commits into from
Nov 6, 2023

Conversation

petamoriken
Copy link
Contributor

fixes #18802

This PR adds util.toUSVString to node:util:

import util from "node:util";
util.toUSVString("string\ud801"); // => "string\ufffd"

@petamoriken
Copy link
Contributor Author

@bartlomieju please take a look

bartlomieju
bartlomieju approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @petamoriken!

@bartlomieju bartlomieju merged commit 90189dd into denoland:main Nov 6, 2023
13 checks passed
@petamoriken petamoriken deleted the fix/usv-string branch November 7, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use String#toWellFormed in ext/webidl and ext/node
2 participants
@petamoriken @bartlomieju