chore: remove third_party submodule #20201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Aug 18, 2023
|
|
||
| const url = `${downloadUrl}/${toolName}${executableSuffix}`; | ||
|
|
||
| const resp = await fetch(url); |
There was a problem hiding this comment.
What happens if the response is not successful?
There was a problem hiding this comment.
spinner fails and throws an error.
littledivy
added a commit
to littledivy/deno
that referenced
this pull request
Aug 21, 2023
removes third_party submodule, tools are installed on-demand. - removed `load_test` and websocket benchmark (covered by benchy) - removed node/bun http benchmarks (covered by benchy) - `dlint` & `dprint` downloaded on-demand. - `wrk` & `hyperfine` downloaded before CI benchmark run. Install locally using: `./tools/install_prebuilt.js wrk hyperfine` #### updating dlint/dprint update version in `tools/util.js` and place binary in `denoland/deno_third_party`.
littledivy
added a commit
that referenced
this pull request
Aug 21, 2023
removes third_party submodule, tools are installed on-demand. - removed `load_test` and websocket benchmark (covered by benchy) - removed node/bun http benchmarks (covered by benchy) - `dlint` & `dprint` downloaded on-demand. - `wrk` & `hyperfine` downloaded before CI benchmark run. Install locally using: `./tools/install_prebuilt.js wrk hyperfine` #### updating dlint/dprint update version in `tools/util.js` and place binary in `denoland/deno_third_party`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes third_party submodule, tools are installed on-demand.
load_testand websocket benchmark (covered by benchy)dlint&dprintdownloaded on-demand.wrk&hyperfinedownloaded before CI benchmark run.Install locally using:
./tools/install_prebuilt.js wrk hyperfineupdating dlint/dprint
update version in
tools/util.jsand place binary indenoland/deno_third_party.