fix(ext/net): implement a graceful error on an invalid SSL certificate #20157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xIchigo
changed the title
mmastrac
reviewed
Aug 14, 2023
mmastrac
reviewed
Aug 14, 2023
mmastrac
reviewed
Aug 14, 2023
|
@0xIchigo Looks like the lint failed -- run |
|
@mmastrac My apologies, fixed with this commit ! |
|
@0xIchigo Looks like the tests failed, but it's not clear why. I'll take a quick look to figure out what's broken. |
mmastrac
force-pushed
the
fix/panic-on-invalid-ssl
branch
from
7de68dc
to
79b4d31
Compare
mmastrac
approved these changes
Aug 14, 2023
|
Thank you so much @mmastrac for all your help! I'll be on the lookout for any other code I can contribute to in the future 🔥 |
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Aug 21, 2023
denoland#20157) The goal of this PR is to address issue denoland#19520 where Deno panics when encountering an invalid SSL certificate. This PR achieves that goal by removing an `.expect()` statement and implementing a match statement on `tsl_config` (found in [/ext/net/ops_tsl.rs](https://github.com/denoland/deno/blob/e071382768fa57b5288a6a5ba90e73bf5870b169/ext/net/ops_tls.rs#L1058)) to check whether the desired configuration is valid --------- Co-authored-by: Matt Mastracci <[email protected]>
littledivy
pushed a commit
that referenced
this pull request
Aug 21, 2023
#20157) The goal of this PR is to address issue #19520 where Deno panics when encountering an invalid SSL certificate. This PR achieves that goal by removing an `.expect()` statement and implementing a match statement on `tsl_config` (found in [/ext/net/ops_tsl.rs](https://github.com/denoland/deno/blob/e071382768fa57b5288a6a5ba90e73bf5870b169/ext/net/ops_tls.rs#L1058)) to check whether the desired configuration is valid --------- Co-authored-by: Matt Mastracci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to address issue #19520 where Deno panics when encountering an invalid SSL certificate.
This PR achieves that goal by removing an
.expect()statement and implementing a match statement ontsl_config(found in /ext/net/ops_tsl.rs) to check whether the desired configuration is valid