feat(runtime): Provide environment-configurable options for tokio parameters #19173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
May 17, 2023
| )) | ||
| .max_io_events_per_tick(tokio_env( | ||
| "TOKIO_MAX_IO_EVENTS_PER_TICK", | ||
| max_io_events_per_tick, |
There was a problem hiding this comment.
I'm not sure if we want to change this value - IIRC @littledivy said that increasing it, makes performance worse on Mac, but better on Linux.
@littledivy can you chime in?
There was a problem hiding this comment.
If that's the case, that's good to know -- we can use #[cfg(...)] to create a linux/mac tokio_configuration that's somewhat tuned on each platform.
There was a problem hiding this comment.
512 max events per tick seems to help in pure hello-world. I would like to confirm this again - I think it might slow things down with mixed workloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.