fix(kv): kv.close() interrupts in-flight operations #19076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsejcksn
reviewed
May 18, 2023
Comment on lines
2051
to
2057
| /** | ||
| * Close the database connection. This will prevent any further operations | ||
| * from being performed on the database, but will wait for any in-flight | ||
| * operations to complete before closing the underlying database connection. | ||
| * from being performed on the database, and interrupt any in-flight | ||
| * operations immediately. | ||
| */ | ||
| close(): Promise<void>; | ||
| close(): void; | ||
| } |
There was a problem hiding this comment.
The updated JSDoc describes a significant difference in behavior, and I don't see any associated runtime changes. Was the description simply incorrect before?
There was a problem hiding this comment.
@jsejcksn yes, somehow it slipped through the cracks during the review.
mmyoji
added a commit
to mmyoji/bookmark
that referenced
this pull request
May 19, 2023
mmyoji
added a commit
to mmyoji/bookmark
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19049