New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/crypto): ecdh spki key import/export roundtrip #16152

Merged

littledivy merged 1 commit into denoland:main from panva:fix-15523

Oct 4, 2022

Contributor

panva commented Oct 4, 2022

This change removes the use of OID 1.3.132.1.12 (id-ecDH) in ECDH spki export.

it is not interoperable with other implementations
it cannot be imported by Deno's own implementation

closes #15523

Contributor Author

panva commented Oct 4, 2022

panva changed the title ~~fix(ext/crypto): ecdh spki key import/export rountrip~~ fix(ext/crypto): ecdh spki key import/export roundtrip


fix(ext/crypto): ecdh spki key import/export roundtrip

398c722

closes #15523

panva mentioned this pull request

fix(ext/crypto): interoperable import/export #16153

Merged

littledivy approved these changes

View reviewed changes

littledivy merged commit aa710aa into denoland:main

littledivy pushed a commit that referenced this pull request


fix(ext/crypto): interoperable import/export (#16153)

0d042d8

This PR updates RSA key import/export to a state which is interoperable
with other implementations.

For RSA the only OID in and out is `rsaEncryption`.
For EC the only OID in and out is `id-ecpublickey` (fixed in #16152).

see w3c/webcrypto#307 (comment)
see w3c/webcrypto#307
see w3c/webcrypto#305
see nodejs/node#42816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment