Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): curve25519 import export #16140

Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix(ext/crypto): curve25519 import export #16140

merged 1 commit into from
Oct 4, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 3, 2022 •
edited
Loading

This PR fixes a number of issues after skimming through the incomplete implementation from #14119

This ought to push Ed25519 to a usable state. X25519 not so much yet, it is still missing JWK private export and key/bits derivation with which I am unable to help.

@panva panva changed the title Ed25519 import/export fixes fix(ext/crypto): ed25519 import export fixes Oct 3, 2022
@panva
Copy link
Contributor Author

panva commented Oct 3, 2022

cc @littledivy

@panva panva changed the title fix(ext/crypto): ed25519 import export fixes fix(ext/crypto): ed25519 import export Oct 3, 2022
@panva panva changed the title fix(ext/crypto): ed25519 import export fix(ext/crypto): curve25519 import export Oct 3, 2022
@panva panva marked this pull request as draft October 3, 2022 22:13
@panva panva marked this pull request as ready for review October 3, 2022 23:16
@littledivy littledivy mentioned this pull request Oct 4, 2022
Open
4 tasks
littledivy
littledivy approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you. I'll look into X25519 derive and JWK

@littledivy littledivy merged commit 7742ad7 into denoland:main Oct 4, 2022
@panva panva mentioned this pull request Oct 4, 2022
Merged
@panva panva deleted the curve25519-fixes branch October 4, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panva @littledivy