refactor(bench): continuous benchmarking improvements #14821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "main" of github.com:denoland/deno into continuous_bench
littledivy
changed the title
ry
reviewed
Jun 21, 2022
ry
reviewed
Jun 21, 2022
ry
reviewed
Jun 21, 2022
| pub async fn new() -> Self { | ||
| dotenv::dotenv().ok(); | ||
| let gcloud_client = | ||
| match std::env::var("CI").map(|_| std::env::var("GOOGLE_SVC_KEY")) { |
bartlomieju
reviewed
Jun 26, 2022
| @@ -4977,16 +5103,27 @@ version = "0.7.1" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "a156c684c91ea7d62626509bce3cb4e1d9ed5c4d978f7b4352658f96a4c26b4a" | |||
|
|
|||
| [[package]] | |||
There was a problem hiding this comment.
It"s concerning how many changed happened in this file... Is there a way we could reuse the same version (for example by cargo update --package that imports this version)
There was a problem hiding this comment.
cargo update --package url:2.2.2 does not work. Maybe because the difference is of a major version. I"ll submit an upstream patch to upgrade url https://github.com/Byron/google-apis-rs/blob/f00ca37fa4e96657f051292fc8ac610b80373c65/etc/api/type-api.yaml?q=1.7#L30
piscisaureus
approved these changes
Jun 28, 2022
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves Deno"s benchmarking workflow like:
cargo bench --bench deno_bench -- bundledeno.land/benchmarks