refactor: Move source map lookups to core #14274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been blocking lots of other cleanups as well. Namely the following transformations gradually faced by
JsError
have all been moved up front toJsError::from_v8_exception()
: finding the first non-deno:
source line [old code]; movingJsError::script_resource_name
etc. into the first error stack in case of syntax errors [old code]; source mappingJsError::script_resource_name
etc. when wrapping the error even though the frame locations are source mapped earlier [old code]; removingJsError::{script_resource_name,line_number,start_column,end_column}
entirely in favour ofjs_error.frames.get(0)
. We also no longer pass a js-side callback tocore/02_error.js
from cli. I avoided doing this on previous occasions because the source map lookups were in an awkward place.