Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Rust version to 1.56.1 #12870

Merged
merged 3 commits into from
Nov 24, 2021
Merged

chore: upgrade Rust version to 1.56.1 #12870

merged 3 commits into from
Nov 24, 2021

Conversation

abdfnx
Copy link
Contributor

@abdfnx abdfnx commented Nov 23, 2021

upgrade Rust version to 1.56.1 in

  1. .devcontainer/Dockerfile
  2. .github/workflows/ci.yml

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2021

CLA assistant check
All committers have signed the CLA.

@dsherret
Copy link
Member

Looks like the CI keeps saying it's out of space. Maybe the cache needs to be cleared somehow when doing this upgrade? I'm not sure how to do that on the CI.

@abdfnx
Copy link
Contributor Author

abdfnx commented Nov 24, 2021

ok, so is the problem is from me or from the CI ?

@bartlomieju
Copy link
Member

ok, so is the problem is from me or from the CI ?

I pushed a commit that rotates cache keys, let's see if it helps.

@abdfnx
Copy link
Contributor Author

abdfnx commented Nov 24, 2021

ok, so is the problem is from me or from the CI ?

I pushed a commit that rotates cache keys, let's see if it helps.

looks like you fixed it

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @abdfnx!

And thanks Bartek for busting the cache :)

@dsherret dsherret merged commit 88000b5 into denoland:main Nov 24, 2021
@abdfnx
Copy link
Contributor Author

abdfnx commented Nov 24, 2021

LGTM. Thanks @abdfnx!

And thanks Bartek for busting the cache :)

glad to help @denoland

deno one of the best tools that I used ever

piscisaureus pushed a commit that referenced this pull request Nov 24, 2021
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants