Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --lock-write #24167

Open
ry opened this issue Jun 10, 2024 · 2 comments
Open

Remove --lock-write #24167

ry opened this issue Jun 10, 2024 · 2 comments
Assignees
@bartlomieju
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Milestone
2.0

Comments

@ry
Copy link
Member

ry commented Jun 10, 2024

No description provided.

@lucacasonato lucacasonato added the feat new feature (which has been agreed to/accepted) label Jun 11, 2024
@lucacasonato lucacasonato added this to the 2.0 milestone Jun 11, 2024
@lucacasonato lucacasonato added the cli related to cli/ dir label Jun 11, 2024
@dsherret
Copy link
Member

Reasoning:

  • It's currently confusing what this does
  • This is equivalent to deleting the lockfile and recreating it
  • There will be a new --frozen/--frozen-lockfile flag (and ability to specify this in the config file)

@dsherret dsherret mentioned this issue Jun 13, 2024
Closed
@bartlomieju bartlomieju modified the milestones: 2.0, 1.45 Jul 2, 2024
@bartlomieju bartlomieju self-assigned this Jul 2, 2024
@bartlomieju bartlomieju mentioned this issue Jul 4, 2024
Merged
bartlomieju added a commit that referenced this issue Jul 5, 2024
@bartlomieju
feat: Deprecate --lock-write flag (#24436)
0bbfd6f 
This commit deprecates `--lock-write` flag by removing it from
the help output and printing a warning message when it's used.

Users should use `--frozen=false` instead which was added
in #24355.

Towards #24167.
@bartlomieju
Copy link
Member

This flag has been deprecated in #24436, will be removed in Deno 2.

@bartlomieju bartlomieju changed the title Deprecate / Remove --lock-write Remove --lock-write Jul 6, 2024
@bartlomieju bartlomieju modified the milestones: 1.45, 2.0 Jul 6, 2024
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@bartlomieju @zebreus
feat: Deprecate --lock-write flag (denoland#24436)
fe40ac7 
This commit deprecates `--lock-write` flag by removing it from
the help output and printing a warning message when it's used.

Users should use `--frozen=false` instead which was added
in denoland#24355.

Towards denoland#24167.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@ry @dsherret @lucacasonato @bartlomieju