Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[publish] exporting a name imported via equals import results in an error #23388

Closed
teidesu opened this issue Apr 15, 2024 · 0 comments · Fixed by #23421
Closed

[publish] exporting a name imported via equals import results in an error #23388

teidesu opened this issue Apr 15, 2024 · 0 comments · Fixed by #23421
Assignees
@dsherret
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand

Comments

@teidesu
Copy link

teidesu commented Apr 15, 2024 •
edited
Loading

mcve

mod.ts

import * as inner from './inner.ts'
import foo = inner.foo
export { foo }

inner.ts

export const foo = 123

and run deno publish

error

error: Failed ensuring public API type output is valid.

TS2304 [ERROR]: Cannot find name 'foo'.
export { foo };
         ~~~
    at file:///path/to/mod.ts:3:10

You may have discovered a bug in Deno. Please open an issue at: https://github.com/denoland/deno/issues/

additional info

replacing import foo = with const foo = works fine in this case, but wouldn't if foo was a type

version

deno 1.42.3 76df7d7 (canary, aarch64-apple-darwin)
v8 12.3.219.9
typescript 5.4.3
@dsherret dsherret added bug Something isn't working correctly publish Related to "deno publish" subcommand labels Apr 15, 2024
@dsherret dsherret self-assigned this Apr 15, 2024
This was referenced Apr 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(publish): support import equals denoland/deno
2 participants
@dsherret @teidesu