Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Workspaces only searches for deno.json instead of also deno.jsonc #23343

Closed
marvinhagemeister opened this issue Apr 12, 2024 · 2 comments · Fixed by #23480 or #23492
Closed

Bug: Workspaces only searches for deno.json instead of also deno.jsonc #23343

marvinhagemeister opened this issue Apr 12, 2024 · 2 comments · Fixed by #23480 or #23492
Labels
bug Something isn't working correctly
Milestone
1.43

Comments

@marvinhagemeister
Copy link
Contributor

The workspace resolution logic seems to only look for deno.json files and not deno.jsonc files.

Steps to reproduce

  1. Clone https://github.com/marvinhagemeister/deno-workspace-jsonc-bug
  2. Run deno run main.ts

Error

$ deno run -A main.ts 
error: Workspace member 'foo' has no deno.json file ('/Users/marvinh/dev/test/deno-workspace/foo/deno.json')

Version: Deno 1.42.3
@marvinhagemeister marvinhagemeister added the bug Something isn't working correctly label Apr 12, 2024
@king8fisher
Copy link
Contributor

making json extension work for both content types would make life so much easier 😄

@bartlomieju bartlomieju added this to the 1.43 milestone Apr 12, 2024
@bartlomieju bartlomieju mentioned this issue Apr 20, 2024
Merged
bartlomieju added a commit to denoland/deno_config that referenced this issue Apr 21, 2024
@bartlomieju
fix: look for deno.json and deno.jsonc for workspace members (#50)
4861469 
Fixing denoland/deno#23343
@bartlomieju bartlomieju mentioned this issue Apr 21, 2024
Merged
bartlomieju added a commit that referenced this issue Apr 21, 2024
@bartlomieju
chore: update deno_config to 0.16.1 (#23480)
a2bd1a7 
Closes #23343
@bartlomieju bartlomieju reopened this Apr 21, 2024
@bartlomieju
Copy link
Member

New error:

../deno/target/debug/deno run main.ts
error: Relative import path "@marvinh-test/bar" not prefixed with / or ./ or ../ and not in import map from "file:///Users/ib/dev/deno-workspace-jsonc-bug/main.ts"
    at file:///Users/ib/dev/deno-workspace-jsonc-bug/main.ts:2:22

@bartlomieju bartlomieju mentioned this issue Apr 22, 2024
Merged
bartlomieju added a commit that referenced this issue Apr 23, 2024
@bartlomieju
fix(workspace): provide workspace members as 'imports' in import map (#…
35220f0 
…23492)

This commit changes the workspace support to provide all workspace
members to be available as imports based on their names and versions.

Closes #23343
@lowlighter lowlighter mentioned this issue Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
1.43
3 participants
@marvinhagemeister @bartlomieju @king8fisher