-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thread 'main' panicked at runtime/permissions/lib.rs:695:19 #23294
Comments
Please provide a reproducible example |
Repro:
|
This bug was introduced in #23084 and makes it impossible to listen on an IPv6 address ( |
Hi, i will work on fix this bug, |
|
I am trying to push code for fix but i don't have permissions for pushing. remote: Permission to denoland/deno.git denied to yazan-nidal. |
…acro This commit addresses issue denoland#23294 by enhancing the error handling and dot handling logic within the fqdn! macro. Specifically, it: - Handles parsing errors gracefully using pattern matching instead of unwrap(). - Adjusts substring parsing to correctly handle domain names ending with a dot. This change improves the reliability and robustness of the fqdn! macro, ensuring more accurate parsing of fully qualified domain names. Fixes: denoland#23294
what did u mean with error gracefully? |
Yes, it should print the error and exit. That means you just need to return an |
…n! macro This commit addresses issue (denoland#23294 , denoland#23552) by enhancing the error handling and dot handling logic within the fqdn! macro. Specifically, it: Handles parsing errors gracefully using pattern matching instead of unwrap(). Adjusts substring parsing to correctly handle domain names ending with a dot. This change improves the reliability and robustness of the fqdn! macro, ensuring more accurate parsing of fully qualified domain names. Fixes: denoland#23294 , denoland#23552
Platform: linux x86_64
Version: 1.42.1
Args: ["deno", "run", "icallersa.js"]
thread 'main' panicked at runtime/permissions/lib.rs:695:19:
called
Result::unwrap()
on anErr
value: InvalidLabelCharstack backtrace:
0: rust_begin_unwind
at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
1: core::panicking::panic_fmt
at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
2: core::result::unwrap_failed
at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/result.rs:1649:5
3: core::result::Result<T,E>::unwrap
4: deno_permissions::UnaryPermission<deno_permissions::NetDescriptor>::check_url
5: deno_fetch::op_fetch::v8_fn_ptr
6: Builtins_CallApiCallbackGeneric
The text was updated successfully, but these errors were encountered: