-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace should be detected when cwd is in a package of a workspace #22020
Closed
Tracked by
#22942
Labels
Comments
dsherret
changed the title
Workspace should be detected when in a package of a workspace
Workspace should be detected when cwd is in a package of a workspace
Mar 13, 2024
12 tasks
zebreus
pushed a commit
to zebreus/deno
that referenced
this issue
Jul 8, 2024
Adds much better support for the unstable Deno workspaces as well as support for npm workspaces. npm workspaces is still lacking in that we only install packages into the root node_modules folder. We'll make it smarter over time in order for it to figure out when to add node_modules folders within packages. This includes a breaking change in config file resolution where we stop searching for config files on the first found package.json unless it's in a workspace. For the previous behaviour, the root deno.json needs to be updated to be a workspace by adding `"workspace": ["./path-to-pkg-json-folder-goes-here"]`. See details in denoland/deno_config#66 Closes denoland#24340 Closes denoland#24159 Closes denoland#24161 Closes denoland#22020 Closes denoland#18546 Closes denoland#16106 Closes denoland#24160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to make workspaces work well when your cwd or script specified is in a package. Probably if a deno.json contains a name and version, we should continue searching the directory tree for the root deno.json
While doing this, add tests for #22004
The text was updated successfully, but these errors were encountered: