perf(ext/web): Avoid changing prototype by setting hostObjectBrand di…

…rectly (#21358)
denoland · Nov 30, 2023 · 8050cbf · 8050cbf
1 parent ffa0954
commit 8050cbf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -40,7 40,7 @@ repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
 deno_ast = { version = "0.31.6", features = ["transpiling"] }
-deno_core = { version = "0.233.0" }
 deno_core = { version = "0.234.0" }
 
 deno_runtime = { version = "0.133.0", path = "./runtime" }
 napi_sym = { version = "0.55.0", path = "./cli/napi/sym" }

diff --git a/ext/web/13_message_port.js b/ext/web/13_message_port.js
@@ -26,7 26,6 @@ const {
  ArrayPrototypeIncludes,
  ArrayPrototypePush,
  ObjectPrototypeIsPrototypeOf,
- ObjectSetPrototypeOf,
  Symbol,
  SymbolFor,
  SymbolIterator,
@@ -84,9 83,8 @@ const _enabled = Symbol("enabled");
  * @returns {MessagePort}
  */
 function createMessagePort(id) {
- const port = core.createHostObject();
- ObjectSetPrototypeOf(port, MessagePortPrototype);
- port[webidl.brand] = webidl.brand;
  const port = webidl.createBranded(MessagePort);
  port[core.hostObjectBrand] = core.hostObjectBrand;
  setEventTargetData(port);
  port[_id] = id;
  return port;