refactor(jupyter): move ZeroMQ server to a separate thread (#24373)

Moves the ZeroMQ messaging server to a separate thread. This will allow to run blocking JS code and maintain communication with the notebook frontend. Towards #23592 Towards #24250 Closes #23617
denoland · Jul 2, 2024 · 7d919f6 · 7d919f6
1 parent c13b6d1
commit 7d919f6
Show file tree

Hide file tree

Showing 4 changed files with 484 additions and 151 deletions.
diff --git a/cli/ops/jupyter.rs b/cli/ops/jupyter.rs
@@ -45,11 45,11 @@ pub async fn op_jupyter_broadcast(
 
  (
  s.borrow::<Arc<Mutex<KernelIoPubConnection>>>().clone(),
- s.borrow::<Rc<RefCell<Option<JupyterMessage>>>>().clone(),
  s.borrow::<Arc<Mutex<Option<JupyterMessage>>>>().clone(),
  )
  };
 
- let maybe_last_request = last_execution_request.borrow().clone();
  let maybe_last_request = last_execution_request.lock().await.clone();
  if let Some(last_request) = maybe_last_request {
  let content = JupyterMessageContent::from_type_and_content(
  &message_type,