fix(cli): formatting bench with colors (#19323)

denoland · Jun 7, 2023 · 28ce0ef · 28ce0ef
1 parent 42c10ec
commit 28ce0ef
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/cli/tests/integration/bench_tests.rs b/cli/tests/integration/bench_tests.rs
@@ -43,6 43,12 @@ itest!(fail {
  output: "bench/fail.out",
 });
 
 itest!(bench_formatting {
  args: "bench bench/bench_formatting.ts",
  exit_code: 0,
  output: "bench/bench_formatting.out",
 });
 
 itest!(collect {
  args: "bench --ignore=bench/collect/ignore bench/collect",
  exit_code: 0,

diff --git a/cli/tests/testdata/bench/bench_formatting.out b/cli/tests/testdata/bench/bench_formatting.out
@@ -0,0 1,8 @@
 Check [WILDCARD]/bench/bench_formatting.ts
 cpu: [WILDCARD]
 runtime: deno [WILDCARD] ([WILDCARD])
 
 [WILDCARD]/bench/bench_formatting.ts
 benchmark time (avg) (min … max) p75 p99 p995
 ------------------------------------------------- -----------------------------
 [WILDCARD] [WILDCARD] [WILDCARD]/iter[WILDCARD]([WILDCARD] … [WILDCARD]) [WILDCARD]
diff --git a/cli/tests/testdata/bench/bench_formatting.ts b/cli/tests/testdata/bench/bench_formatting.ts
@@ -0,0 1,3 @@
 Deno.bench("Date.now", () => {
  Date.now();
 });
diff --git a/cli/tools/bench.rs b/cli/tools/bench.rs
@@ -1147,13 1147,13 @@ mod mitata {
  } else {
  if options.avg {
  s.push_str(&format!(
- "{:>23}",
  "{:>30}",
  format!("{}/iter", colors::yellow(fmt_duration(stats.avg)))
  ));
  }
  if options.min_max {
  s.push_str(&format!(
- "{:>42}",
  "{:>50}",
  format!(
  "({} … {})",
  colors::cyan(fmt_duration(stats.min)),
@@ -1163,7 1163,7 @@ mod mitata {
  }
  if options.percentiles {
  s.push_str(&format!(
- " {:>18} {:>18} {:>18}",
  " {:>22} {:>22} {:>22}",
  colors::magenta(fmt_duration(stats.p75)),
  colors::magenta(fmt_duration(stats.p99)),
  colors::magenta(fmt_duration(stats.p995))