Skip to content

Commit

Permalink
fix(ext/node): rewrite digest handling (#24392)
Browse files Browse the repository at this point in the history
Previously we had many different code paths all
handling digests in different places, all with
wildly different digest support. This commit
rewrites this to use a single digest handling
mechanism for all digest operations.

It adds various aliases for digest algorithms,
like node does. For example
`sha1WithRSAEncryption` is an alias for `sha1`.

It also adds support for `md5-sha1` digests in
various places.
  • Loading branch information
lucacasonato committed Jul 5, 2024
1 parent b290fd0 commit 08e5606
Show file tree
Hide file tree
Showing 19 changed files with 1,219 additions and 294 deletions.
2 changes: 1 addition & 1 deletion ext/crypto/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 35,7 @@ ring = { workspace = true, features = ["std"] }
rsa.workspace = true
serde.workspace = true
serde_bytes.workspace = true
sha1 = { version = "0.10.6", features = ["oid"] }
sha1.workspace = true
sha2.workspace = true
signature.workspace = true
spki.workspace = true
Expand Down
6 changes: 3 additions & 3 deletions ext/node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 49,7 @@ k256 = "0.13.1"
lazy-regex.workspace = true
libc.workspace = true
libz-sys.workspace = true
md-5 = "0.10.5"
md-5 = { version = "0.10.5", features = ["oid"] }
md4 = "0.10.2"
num-bigint.workspace = true
num-bigint-dig = "0.8.2"
Expand All @@ -66,14 66,14 @@ rand.workspace = true
regex.workspace = true
reqwest.workspace = true
ring.workspace = true
ripemd = "0.1.3"
ripemd = { version = "0.1.3", features = ["oid"] }
rsa.workspace = true
scrypt = "0.11.0"
sec1 = "0.7"
serde = "1.0.149"
sha1.workspace = true
sha2.workspace = true
sha3 = "0.10.8"
sha3 = { version = "0.10.8", features = ["oid"] }
signature.workspace = true
simd-json = "0.13.4"
sm3 = "0.4.2"
Expand Down
Loading

0 comments on commit 08e5606

Please sign in to comment.