Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump plug to version 1.0.1 #81

Merged
merged 7 commits into from
Feb 6, 2023
Merged

feat: bump plug to version 1.0.1 #81

merged 7 commits into from
Feb 6, 2023

Conversation

eliassjogreen
Copy link
Contributor

No description provided.

@DjDeveloperr
Copy link
Member

The CI is failing with a weird error, try rebasing

@eliassjogreen
Copy link
Contributor Author

@DjDeveloperr The current CI error seems to be because of a flaky test? I get this error locally sometime on my windows machine too when running the tests, even without the changes in this PR.

@DjDeveloperr
Copy link
Member

Huh the CI on main seems to pass every time (I tried multiple runs) but never passed on the PR 🤔

@eliassjogreen eliassjogreen changed the title feat: bump plug to version 1.0.0 feat: bump plug to version 1.0.1 Feb 4, 2023
@DjDeveloperr
Copy link
Member

I'll look into this PR as soon as I find some time

@DjDeveloperr
Copy link
Member

The problem is I can't reproduce this on my local Windows machine...

@DjDeveloperr
Copy link
Member

I think I may have found the fix, try rebasing now

@DjDeveloperr
Copy link
Member

Is the PR tested locally? The CI does not seem to test the plug actually downloading the binary.

@eliassjogreen
Copy link
Contributor Author

Worked on my windows computer a week ago and when tested on a mac without sudo it gave a PermissionDenied error but otherwise worekd fine. I will look into this as it seems to be a plug issue with write permissions.

@DjDeveloperr
Copy link
Member

Did the permission issue on macOS exist before, or is that something recent?

@eliassjogreen
Copy link
Contributor Author

It was probably an issue before too, and there is a resolved similar issue in the plug repo from a little while ago.

Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. Otherwise, LGTM! Thanks

@DjDeveloperr DjDeveloperr merged commit 3b6a098 into denodrivers:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants