Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement backup api #112

Merged
merged 4 commits into from
Nov 21, 2023
Merged

feat: implement backup api #112

merged 4 commits into from
Nov 21, 2023

Conversation

ayn2op
Copy link
Contributor

@ayn2op ayn2op commented Nov 20, 2023 •
edited
Loading

Closes #51

@DjDeveloperr
Copy link
Member

Looks good to me, thanks for the contribution!
I think we should add tests as well

DjDeveloperr
DjDeveloperr approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DjDeveloperr DjDeveloperr merged commit dc9cbf2 into denodrivers:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Backup API
2 participants
@ayn2op @DjDeveloperr